Add a simple server to test against #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! Adding a test server to eliminate external dependencies is definitely a good approach for solving #58. The concept of having a local server for testing is solid. However, I can see that the CI tests are failing, likely due to PHP compatibility issues. The tests appear to be written for newer PHP versions but our current CI setup tests against PHP 7.1+. Could you make sure your code is compatible with PHP 7.1 so the tests pass? Once the compatibility issues are resolved and the tests are green, we'd be happy to review this properly. The functionality itself looks useful, it just needs to work with our supported PHP versions. Thanks for the contribution! |
kiike
force-pushed
the
tests/server
branch
3 times, most recently
from
5ff8cba to
89c25ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to help solve #58 and learn more about the library, so I created a simple web server to test against. It provides a single method to add two integers as a building block for AGI. Since the servers runs locally, no internet access is needed, plus we can ensure the tests don't rely on an external service.
This PR does not depend on #62, but won't pass cleanly without it, due to using
Async\Awaitin a function instead ofClue\React\Block.Fixes #58.